This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.smith
Recipients eric.smith, pitrou
Date 2013-04-01.22:00:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1364853655.88.0.718145768613.issue17612@psf.upfronthosting.co.za>
In-reply-to
Content
In the mail hook, there's a comment that says:

'''
To set the SMTP server to something other than localhost, add a [smtp]
section to your hgrc:

[smtp]
host = mail.python.org
port = 25
'''

This is not true. The default host is '', which tells smtplib.SMTP to not make an initial connection. If we want the comment to be correct, then we need to set 'localhost' as the default:

-    host = ui.config('smtp', 'host', '')
+    host = ui.config('smtp', 'host', 'localhost')

I guess there's some chance that we want to force the smtp host to be set. If that's the case then then comment should be changed and the code modified to require the host be specified in the config file (or at least a better error message than 'please run connect() first').

Adding Antoine because annotate points to him for these lines.
History
Date User Action Args
2013-04-01 22:00:55eric.smithsetrecipients: + eric.smith, pitrou
2013-04-01 22:00:55eric.smithsetmessageid: <1364853655.88.0.718145768613.issue17612@psf.upfronthosting.co.za>
2013-04-01 22:00:55eric.smithlinkissue17612 messages
2013-04-01 22:00:55eric.smithcreate