Message 184534 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gward
Recipients	barry, durin42, gward, ncoghlan, r.david.murray, terry.reedy
Date	2013-03-18.21:48:48
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1363643328.71.0.129214706939.issue17445@psf.upfronthosting.co.za>
In-reply-to

Content
OK I now have two competing patches. Both are disgusting, but in different ways. 1) http://hg.gerg.ca/cpython/rev/fcf3d27f20d9 - factor out all the string constants - always concatenate, do not .format() 2) http://hg.gerg.ca/cpython/rev/cebefce2cfd4 - copy {unified,context}_diff() to {unified,context}_diff_bytes() - this is a future maintenance headache, guaranteed! Feedback welcome. If anyone can see a way to unify these two approaches, or a third way that sucks less, I'm all ears.

OK I now have two competing patches. Both are disgusting, but in different ways.

1) http://hg.gerg.ca/cpython/rev/fcf3d27f20d9
   - factor out all the string constants
   - always concatenate, do not .format()

2) http://hg.gerg.ca/cpython/rev/cebefce2cfd4
   - copy {unified,context}_diff() to {unified,context}_diff_bytes()
   - this is a future maintenance headache, guaranteed!

Feedback welcome. If anyone can see a way to unify these two approaches, or a third way that sucks less, I'm all ears.

History
Date	User	Action	Args
2013-03-18 21:48:48	gward	set	recipients: + gward, barry, terry.reedy, ncoghlan, durin42, r.david.murray
2013-03-18 21:48:48	gward	set	messageid: <1363643328.71.0.129214706939.issue17445@psf.upfronthosting.co.za>
2013-03-18 21:48:48	gward	link	issue17445 messages
2013-03-18 21:48:48	gward	create