Author giampaolo.rodola
Recipients eric.araujo, giampaolo.rodola, pitrou, rosslagerwall
Date 2013-03-08.19:03:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1362769406.78.0.463645298669.issue13564@psf.upfronthosting.co.za>
In-reply-to
Content
> Because offsets can be negative 

On Linux (and presumably on all POSIX platforms) passing a negative offset results in EINVAL.

> In that case, there's a problem with the patch, since select can block
> arbitrarily long because it doesn't take the socket timeout into
> account.

Right. I will fix that.

> Also, apparently socket.sendall() doesn't retry on EAGAIN, 
> it doesn't use BEGIN_SELECT_LOOP.

socket.sendall() is not supposed to return EAGAIN in the first place. And again, I don't see how this is related with the issue at hand.

> I'm leaving this topic, you can do as you like...

Bye.
History
Date User Action Args
2013-03-08 19:03:26giampaolo.rodolasetrecipients: + giampaolo.rodola, pitrou, eric.araujo, rosslagerwall
2013-03-08 19:03:26giampaolo.rodolasetmessageid: <1362769406.78.0.463645298669.issue13564@psf.upfronthosting.co.za>
2013-03-08 19:03:26giampaolo.rodolalinkissue13564 messages
2013-03-08 19:03:26giampaolo.rodolacreate