➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jaraco
Recipients amaury.forgeotdarc, brian.curtin, jaraco, pitrou, python-dev, santoso.wijaya, tim.golden
Date 2013-02-26.13:51:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1361886700.31.0.540407456369.issue13772@psf.upfronthosting.co.za>
In-reply-to
Content 
Please disregard the patch 8bf88b31ebb7.

Antoine, Brian, or anyone else - would you please review the attached patch (b744517b90bc.diff)? It adds a test for creating directory symlinks that are non-local (don't depend on the current directory for reference), backs out Antoine's changes, and replaces them with directory detection that fixes this issue while maintaining directory detection.

I'm not super-confident about the implementation of the path-manipulation functions, and I would prefer to use the Python implementations of the path-manipulation (dirname and join) instead. If there are any suggestions in this regard, I'd appreciate them.

That said, the tests now pass for me on Windows (and I don't see why the tests wouldn't also pass on Linux).
History
Date User Action Args
2013-02-26 13:51:40jaracosetrecipients: + jaraco, amaury.forgeotdarc, pitrou, tim.golden, brian.curtin, santoso.wijaya, python-dev
2013-02-26 13:51:40jaracosetmessageid: <1361886700.31.0.540407456369.issue13772@psf.upfronthosting.co.za>
2013-02-26 13:51:40jaracolinkissue13772 messages
2013-02-26 13:51:40jaracocreate