Message183020
+class FileCookieJar(CookieJar, metaclass=ABCMeta):
+ """Abstract Base Class for any file-based CookieJar."""
Is it just me or is it a bit strange to derive an abstract base class from a concrete class? Is CookieJar meant to be directly used?
+ with open(self.filename) as f:
+ magic = f.readline()
+ if not self.magic_re.search(magic):
+ f.close()
+ raise LoadError(
+ "%r does not look like a Netscape format cookies
f.close() seems not needed as doing that in __exit__ as a major point of with open... statements. |
|
Date |
User |
Action |
Args |
2013-02-26 05:53:13 | terry.reedy | set | recipients:
+ terry.reedy, r.david.murray, docs@python, C19, demian.brecht |
2013-02-26 05:53:13 | terry.reedy | set | messageid: <1361857993.68.0.316343249104.issue16942@psf.upfronthosting.co.za> |
2013-02-26 05:53:13 | terry.reedy | link | issue16942 messages |
2013-02-26 05:53:13 | terry.reedy | create | |
|