Author chris.jerdonek
Recipients chris.jerdonek, gmwils, petri.lehtinen
Date 2013-02-24.04:28:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1361680080.35.0.747146945245.issue15305@psf.upfronthosting.co.za>
In-reply-to
Content
I would be happy to commit and watch the buildbots, once I have confidence in the patch though.  Question: I noticed that the following was changed in Lib/test/regrtest.py:

-    with support.temp_cwd(TESTCWD, quiet=True):
+    with support.temp_cwd(quiet=True, path=TESTCWD):

But the corresponding change wasn't made in Lib/test/__main__.py (which I believe is the code path used by Geoff's `./python.exe -m test -j3` invocation):

http://hg.python.org/cpython/file/96f08a22f562/Lib/test/__main__.py#l12

Those two code chunks should really share code by the way (even the code comment is copied verbatim), which would help in not needing to update code in two places as in this issue/patch.  Perhaps that should even be done first as part of a separate issue (to separate this into smaller changes).
History
Date User Action Args
2013-02-24 04:28:00chris.jerdoneksetrecipients: + chris.jerdonek, petri.lehtinen, gmwils
2013-02-24 04:28:00chris.jerdoneksetmessageid: <1361680080.35.0.747146945245.issue15305@psf.upfronthosting.co.za>
2013-02-24 04:28:00chris.jerdoneklinkissue15305 messages
2013-02-24 04:28:00chris.jerdonekcreate