Author terry.reedy
Recipients benjamin.peterson, eric.araujo, ncoghlan, pitrou, scoder, terry.reedy
Date 2013-02-11.01:46:24
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1360547185.12.0.107768114753.issue17159@psf.upfronthosting.co.za>
In-reply-to
Content
I am puzzled by this part of the patch:

- with self.assertRaisesRegex(TypeError, 'is not a callable object'):
+ with self.assertRaisesRegex(TypeError, '42.*is not a callable object'):

With 3.3, I get "TypeError: 42 is not a callable object", which I consider correct, and which should not be changed by the two changes to signature().  So both the old test, missing '42' (how does it pass?) and the new version, with extraneous '.*' look wrong.

I am also puzzled by the 'from None' part in
+ raise TypeError("'{!r}' is not a Python function".format(func)) from None

While I remember that being in the pydev discussion and while "raise XyzError from None" executes, it does not seems to be documented for 3.3 in 7.8. The raise statement. (Should this be another issue?) In fact, that section says " if given, the second expression must be another exception class or instance", which excludes None.
History
Date User Action Args
2013-02-11 01:46:25terry.reedysetrecipients: + terry.reedy, ncoghlan, pitrou, scoder, benjamin.peterson, eric.araujo
2013-02-11 01:46:25terry.reedysetmessageid: <1360547185.12.0.107768114753.issue17159@psf.upfronthosting.co.za>
2013-02-11 01:46:25terry.reedylinkissue17159 messages
2013-02-11 01:46:24terry.reedycreate