Author berker.peksag
Recipients belopolsky, berker.peksag, mibanescu
Date 2013-02-09.01:45:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1360374315.27.0.872590820179.issue6478@psf.upfronthosting.co.za>
In-reply-to
Content
> There is a long line in _strptime.py which I will fix before
> committing.

Ops, fixed.

Also, I've found a better place for the test in Lib/test/test_strptime.py
and moved it to the test_strptime.CacheTests.

When I applied the patch, test_bad_timezone test failed because of
this code in Lib/_strptime.py:

    @staticmethod
    def _get_timezone():
        try:
            time.tzset()
        except AttributeError:
            pass
        # ...

time.tzset() always resets time.tzname[1], so this part of the code
in test_bad_timezone[2] didn't work.

    tzname = time.tzname[0]
    time.tzname = (tzname, tzname)

I've fixed test_bad_timezone test by mocking the new
_strptime._TimeRE_cache.locale_time._get_timezone method.

[1] http://hg.python.org/cpython/file/default/Modules/timemodule.c#l827
[2] http://hg.python.org/cpython/file/default/Lib/test/test_strptime.py#l320
History
Date User Action Args
2013-02-09 01:45:15berker.peksagsetrecipients: + berker.peksag, belopolsky, mibanescu
2013-02-09 01:45:15berker.peksagsetmessageid: <1360374315.27.0.872590820179.issue6478@psf.upfronthosting.co.za>
2013-02-09 01:45:15berker.peksaglinkissue6478 messages
2013-02-09 01:45:14berker.peksagcreate