This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author xdegaye
Recipients asvetlov, belopolsky, benjamin.peterson, georg.brandl, jcea, pitrou, python-dev, xdegaye
Date 2013-01-23.13:26:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1358947618.47.0.42198110942.issue16672@psf.upfronthosting.co.za>
In-reply-to
Content
The patch applied to the default branch should be reverted.

The 2.7 _hotshot extension module follows the specifications of PyEval_SetTrace:

  """Set the tracing function to func. This is similar to PyEval_SetProfile(),
  except the tracing function does receive line-number events."""
                              ^^^^^^^^^^^^

The 2.7 patch breaks test_hotshot because PyTrace_LINE events are not sent
anymore when f_trace is NULL.

The first patch (already applied to the default branch), breaks also existing
applications that expect to receive line events when they don't care to
implement the following semantics defined by sys.settrace:

  """The trace function is invoked (with event set to 'call') whenever a new
     local scope is entered; it should return a reference to a local trace
     function to be used that scope, or None if the scope shouldn’t be
     traced."""

Those applications want to receive unconditionally line debug events.

Attached is a patch that reverts the patch on the default branch.
History
Date User Action Args
2013-01-23 13:26:58xdegayesetrecipients: + xdegaye, georg.brandl, jcea, belopolsky, pitrou, benjamin.peterson, asvetlov, python-dev
2013-01-23 13:26:58xdegayesetmessageid: <1358947618.47.0.42198110942.issue16672@psf.upfronthosting.co.za>
2013-01-23 13:26:58xdegayelinkissue16672 messages
2013-01-23 13:26:58xdegayecreate