Message 179493 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	serhiy.storchaka
Recipients	Trundle, amaury.forgeotdarc, aronacher, christian.heimes, lars, loewis, neXyon, serhiy.storchaka
Date	2013-01-09.22:13:59
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1357769639.4.0.466857970342.issue9369@psf.upfronthosting.co.za>
In-reply-to

Content
> PyObject_CallMethodObjArgs takes a PyObject, mustn't that be non-const for reference counting to work? Then refcounts.dat wrong. > PyDict_GetItemString already has const, just not in refcounts.dat. Fixed. There are a lot of char arguments in refcounts.dat. If refcounts.dat differs from actual function signature, this is a bug, and fix must be applied to other versions too. If they conform, perhaps this argument can be enhanced to "const char*" in 3.4. Therefore two issues are needed, one for the new feature, and one for the bugfixing.

> PyObject_CallMethodObjArgs takes a PyObject*, mustn't that be non-const for reference counting to work?

Then refcounts.dat wrong.

> PyDict_GetItemString already has const, just not in refcounts.dat. Fixed.

There are a lot of char* arguments in refcounts.dat. If refcounts.dat differs from actual function signature, this is a bug, and fix must be applied to other versions too. If they conform, perhaps this argument can be enhanced to "const char*" in 3.4. Therefore two issues are needed, one for the new feature, and one for the bugfixing.

History
Date	User	Action	Args
2013-01-09 22:13:59	serhiy.storchaka	set	recipients: + serhiy.storchaka, loewis, amaury.forgeotdarc, christian.heimes, aronacher, Trundle, neXyon, lars
2013-01-09 22:13:59	serhiy.storchaka	set	messageid: <1357769639.4.0.466857970342.issue9369@psf.upfronthosting.co.za>
2013-01-09 22:13:59	serhiy.storchaka	link	issue9369 messages
2013-01-09 22:13:59	serhiy.storchaka	create