Author eli.bendersky
Recipients Arfrever, danielsh, einarfd, eli.bendersky, ezio.melotti, flox, georg.brandl, jcea, larry, python-dev, santoso.wijaya, skrah
Date 2013-01-08.14:39:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1357655983.96.0.743600964042.issue16076@psf.upfronthosting.co.za>
In-reply-to
Content
Daniel, thanks for this patch, it looks very good. I had some comments in the code review.

As for TreeBuilder, let's split it into a separate issue - I think it's much less critical. We can discuss it later once we're done with Element. If anything, it's more important to handle ElementTree itself first - it should be very easy (much simpler than Element).

With the factory method I'm not sure how the Py pickling happens. I need to dig a bit in pickling for that, because I don't know how method reference pickling works.
History
Date User Action Args
2013-01-08 14:39:44eli.benderskysetrecipients: + eli.bendersky, georg.brandl, jcea, larry, ezio.melotti, Arfrever, skrah, flox, santoso.wijaya, python-dev, einarfd, danielsh
2013-01-08 14:39:43eli.benderskysetmessageid: <1357655983.96.0.743600964042.issue16076@psf.upfronthosting.co.za>
2013-01-08 14:39:43eli.benderskylinkissue16076 messages
2013-01-08 14:39:43eli.benderskycreate