Author giampaolo.rodola
Recipients christian.heimes, felipecruz, giampaolo.rodola, gvanrossum, neologix, pitrou, rosslagerwall
Date 2013-01-05.14:16:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1357395400.71.0.343635632824.issue16853@psf.upfronthosting.co.za>
In-reply-to
Content
@Guido: agreed.

> there's no SELECT_ERR anymore [...] the error will be reported when the FD will be read/written

I don't think this is a good idea, particularly during this early stage.
This assumption might be valid for select() but not for poll() and epoll() where (POLLERR | POLLHUP | POLLNVAL) is an alias for "connection lost", and that's an event which both Twisted and Tornado take into account and treat differently than a pure "read" event.
The same assumption should also apply for kqueue().

> the exceptions set isn't passed to select() anymore: exception events (like OOB) are already reported in the read or write sets

That's true only if SO_OOBINLINE has been pre-emptively set against the socket.
It might be ok to ignore select()'s exceptional events anyway though.
This is probably another thing you might want to decide later.

> there was something missing/annoying in the API [...]  now, it only accepts only file descriptors, and also an optional opaque 'data' object

I like this change as it avoids maintaining a separate fd->handler map.

Will add line-by-line comments by using the review tool.
History
Date User Action Args
2013-01-05 14:16:40giampaolo.rodolasetrecipients: + giampaolo.rodola, gvanrossum, pitrou, christian.heimes, neologix, rosslagerwall, felipecruz
2013-01-05 14:16:40giampaolo.rodolasetmessageid: <1357395400.71.0.343635632824.issue16853@psf.upfronthosting.co.za>
2013-01-05 14:16:40giampaolo.rodolalinkissue16853 messages
2013-01-05 14:16:40giampaolo.rodolacreate