Author pitrou
Recipients christian.heimes, felipecruz, giampaolo.rodola, gvanrossum, neologix, pitrou, rosslagerwall
Date 2013-01-04.17:06:20
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1357319180.63.0.654930900963.issue16853@psf.upfronthosting.co.za>
In-reply-to
Content
I've posted a review on Rietveld. Not sure the notification e-mail was sent since I got a weird response from the server.

> should EINTR be handled (i.e. retry, with an updated timeout). I'm tempted to say
> yes, because EINTR is just a pain the user should never be exposed with.

You could add an optional argument to the select() method?

> what should be done with POLLNVAL and POLLERR? Raise an exception (that's what Java 
> does, but since you can get quite quite easily it would be a pain to use), return a 
> generic SELECT_ERR event?

I would say return SELECT_ERR.

> So this can be interesting when a large number of FDs are monitored.

The difference is impressive indeed.
History
Date User Action Args
2013-01-04 17:06:20pitrousetrecipients: + pitrou, gvanrossum, giampaolo.rodola, christian.heimes, neologix, rosslagerwall, felipecruz
2013-01-04 17:06:20pitrousetmessageid: <1357319180.63.0.654930900963.issue16853@psf.upfronthosting.co.za>
2013-01-04 17:06:20pitroulinkissue16853 messages
2013-01-04 17:06:20pitroucreate