Author kachayev
Recipients amaury.forgeotdarc, anacrolix, asvetlov, eric.snow, ezio.melotti, giampaolo.rodola, kachayev, meador.inge, pitrou, rhettinger, scoder, serhiy.storchaka, skrah
Date 2012-12-30.20:04:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1356897852.45.0.587685967759.issue14373@psf.upfronthosting.co.za>
In-reply-to
Content
Updated diff with:
 * fix object leaks
 * tp_clear
 * additional test for maxsize < 0

I also reimplemented multithreading test (fixed error and added skip rule). But actually, I'm not sure that it's enough for ensuring thread-safety of clear operation. I'm working on other variant now. I will be appreciated for any advice about where to find example of the same (or close enough) test cases from other modules.

Regarding to previous comments from review. 

1. "guard against negative numbers"

I added special test case for negative maxsize in order to show, that now C version works the same as Python one. So, should we change both implementation? What behavior is most logical here? Reimplementation will change public API, so it's not only about acceleration.

2. Use regular PyObject instead of lru_list_elem.

What the problems are with current implementation?
History
Date User Action Args
2012-12-30 20:04:12kachayevsetrecipients: + kachayev, rhettinger, amaury.forgeotdarc, pitrou, scoder, giampaolo.rodola, ezio.melotti, asvetlov, skrah, meador.inge, anacrolix, eric.snow, serhiy.storchaka
2012-12-30 20:04:12kachayevsetmessageid: <1356897852.45.0.587685967759.issue14373@psf.upfronthosting.co.za>
2012-12-30 20:04:12kachayevlinkissue14373 messages
2012-12-30 20:04:12kachayevcreate