Author chris.jerdonek
Recipients a.kasyanov, asvetlov, benjamin.peterson, chris.jerdonek, ezio.melotti, georg.brandl, orsenthil, r.david.murray, tshepang
Date 2012-12-27.20:09:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1356638953.35.0.521552864544.issue15302@psf.upfronthosting.co.za>
In-reply-to
Content
Rietveld is erroring out on me again whenever I try to reply to a comment, so I'm posting my comment here.

On 2012/12/27 18:29:22, Benjamin Peterson wrote:
> > On 2012/12/27 04:44:33, Benjamin Peterson wrote:
> > > if val:
> > 
> > Again, we need this to match getopt behavior. Using "if val" would replace
> the
> > value provided for all options accepting a value with the empty string. In
> > particular, the test_fromfile() test case (and two others) would fail with
> that
> > change. On the flip side, getopt causes provided boolean options to show up
> as
> > having an empty string value in the return value which is why I'm setting val
> to
> > ''.
> 
> I suppose this stuff is temporary anyway until regrtest can actualy use a nice
> namespace.

Right. That part is a temporary bridge.

I updated the patch based on your original comments, by the way. The patch is a lot simpler now, including dropping the need to subclass ArgumentParser, taking out the old usage() function, simplifying the tests, and making the need for the tests more explicit (which also can be removed after switching to using a namespace object).
History
Date User Action Args
2012-12-27 20:09:13chris.jerdoneksetrecipients: + chris.jerdonek, georg.brandl, orsenthil, benjamin.peterson, ezio.melotti, r.david.murray, asvetlov, tshepang, a.kasyanov
2012-12-27 20:09:13chris.jerdoneksetmessageid: <1356638953.35.0.521552864544.issue15302@psf.upfronthosting.co.za>
2012-12-27 20:09:13chris.jerdoneklinkissue15302 messages
2012-12-27 20:09:12chris.jerdonekcreate