Author serhiy.storchaka
Recipients Arfrever, brett.cannon, jcea, serhiy.storchaka, zach.ware
Date 2012-12-20.11:42:50
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1356003771.08.0.873187979883.issue16694@psf.upfronthosting.co.za>
In-reply-to
Content
Sorry, I forgot push a "Publish All My Drafts" button. Please consider other my comments to first patch. I also have added new comments about length_hint().

Your implementation of attrgetter() looks good. One possible disadvantage of pure functional approach is that attrgetter() will be not a class. Unlikely someone subclass attrgetter, but it can be used in an isinstance() check. You solve this issue.

The same approach can be applied to itemgetter().
History
Date User Action Args
2012-12-20 11:42:51serhiy.storchakasetrecipients: + serhiy.storchaka, brett.cannon, jcea, Arfrever, zach.ware
2012-12-20 11:42:51serhiy.storchakasetmessageid: <1356003771.08.0.873187979883.issue16694@psf.upfronthosting.co.za>
2012-12-20 11:42:51serhiy.storchakalinkissue16694 messages
2012-12-20 11:42:50serhiy.storchakacreate