Author serhiy.storchaka
Recipients Arfrever, christian.heimes, eric.araujo, nadeem.vawda, pitrou, serhiy.storchaka
Date 2012-12-09.17:20:48
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <201212091920.32086.storchaka@gmail.com>
In-reply-to <1355058715.45.0.527712147983.issue15955@psf.upfronthosting.co.za>
Content
> you can just stick "if not output: continue" before it.

And then hang. Because d.unconsumed_tail is not empty and no new data will be 
read.

> Why is this necessary? If unconsumed_tail is b'', then there's no need to
> prepend it (and the concatenation would be a no-op anyway). If
> unconsumed_tail does contain data, then we don't need to read additional
> compressed data from the file until we've finished decompressing the data
> we already have.

What if unconsumed_tail is not empty but less than needed to decompress at 
least one byte? We need read more data until unconsumed_tail grow enought to 
be decompressed.

> Are you proposing that the decompressor object maintain its own buffer, and
> copy the input data into it before passing it to the decompression library?
> Doesn't that just duplicate work that the library is already doing for us?

unconsumed_tail is such buffer and when we call decompressor with new chunk of 
data we should allocate buffer of size (len(unconsumed_tail)+len(compressed)) 
and copy len(unconsumed_tail) bytes from unconsumed_tail and len(compressed) 
from gotten data. But when you use internal buffer, you should only copy new 
data.
History
Date User Action Args
2012-12-09 17:20:48serhiy.storchakasetrecipients: + serhiy.storchaka, pitrou, christian.heimes, nadeem.vawda, eric.araujo, Arfrever
2012-12-09 17:20:48serhiy.storchakalinkissue15955 messages
2012-12-09 17:20:48serhiy.storchakacreate