Author serhiy.storchaka
Recipients ajaksu2, amaury.forgeotdarc, eric.araujo, harobed, lemburg, r.david.murray, serhiy.storchaka, vstinner
Date 2012-12-07.19:52:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1354909954.46.0.868432657554.issue8260@psf.upfronthosting.co.za>
In-reply-to
Content
I think the patch is wrong or is not optimal for case when chars is -1, but size is not.

If we want to read all data in any case, then we should call self.stream.read() without argument if chars < 0 or size < 0.

If we want to read no more than size bytes, then all loop code should be totally rewritten.

Perhaps I am wrong.
History
Date User Action Args
2012-12-07 19:52:34serhiy.storchakasetrecipients: + serhiy.storchaka, lemburg, amaury.forgeotdarc, vstinner, ajaksu2, eric.araujo, r.david.murray, harobed
2012-12-07 19:52:34serhiy.storchakasetmessageid: <1354909954.46.0.868432657554.issue8260@psf.upfronthosting.co.za>
2012-12-07 19:52:34serhiy.storchakalinkissue8260 messages
2012-12-07 19:52:34serhiy.storchakacreate