Author serhiy.storchaka
Recipients anacrolix, asvetlov, eric.snow, ezio.melotti, giampaolo.rodola, meador.inge, nedbat, rhettinger, serhiy.storchaka
Date 2012-11-24.14:19:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1353766766.58.0.838371058979.issue14373@psf.upfronthosting.co.za>
In-reply-to
Content
I have added a lot of comments in Rietveld. In general the patch looks good, but I have some style nitpicks and some more strong comments. Matt, please update the patch.

Tests should test both Python and C implementations.

I doubt if get rid of locking is right. Hash calculation and comparison of arguments can call Python code and this code can recursive use the wrapped function.

Some benchmarks will be interesting.

I think this acceleration must necessarily be in 3.4.
History
Date User Action Args
2012-11-24 14:19:26serhiy.storchakasetrecipients: + serhiy.storchaka, rhettinger, giampaolo.rodola, nedbat, ezio.melotti, asvetlov, meador.inge, anacrolix, eric.snow
2012-11-24 14:19:26serhiy.storchakasetmessageid: <1353766766.58.0.838371058979.issue14373@psf.upfronthosting.co.za>
2012-11-24 14:19:26serhiy.storchakalinkissue14373 messages
2012-11-24 14:19:26serhiy.storchakacreate