Author serhiy.storchaka
Recipients Roman.Evstifeev, eric.araujo, eric.smith, eric.snow, ezio.melotti, loewis, r.david.murray, rafik, ronaldoussoren, santoso.wijaya, serhiy.storchaka
Date 2012-11-13.09:24:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1352798657.28.0.546578580459.issue10395@psf.upfronthosting.co.za>
In-reply-to
Content
Some conclusions of discussion at Python-ideas (http://comments.gmane.org/gmane.comp.python.ideas/17719):

1. commonpath() should eat double slashes in input (['/usr/bin', '/usr//bin'] -> '/usr/bin').  In any case the current implementation eats slashes on output (['/usr//bin', '/usr//bin'] -> '/usr/bin', not '/usr//bin').

2. commonpath() should raise an exception instead of returning None on incompatible input.

3. May be commonpath() should eat also '.' components and return '.' instead of '' when relative paths have no common prefix. I am not sure.

In general the current patch looks good enough.
History
Date User Action Args
2012-11-13 09:24:17serhiy.storchakasetrecipients: + serhiy.storchaka, loewis, ronaldoussoren, eric.smith, ezio.melotti, eric.araujo, r.david.murray, santoso.wijaya, eric.snow, Roman.Evstifeev, rafik
2012-11-13 09:24:17serhiy.storchakasetmessageid: <1352798657.28.0.546578580459.issue10395@psf.upfronthosting.co.za>
2012-11-13 09:24:17serhiy.storchakalinkissue10395 messages
2012-11-13 09:24:17serhiy.storchakacreate