Author pitrou
Recipients pconnell, pitrou, r.david.murray, serhiy.storchaka, vinay.sajip
Date 2012-11-11.13:57:51
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1352642231.3360.6.camel@localhost.localdomain>
In-reply-to <1352641613.38.0.490750411808.issue16449@psf.upfronthosting.co.za>
Content
> I've updated the type to enhancement (it seems like a grey area to me
> - it's a behavioural fix for a niche use case).
> 
> I suggested a patch rather than simply subclassing RotatingFileHandler
> since:
>   - The subclass would just have a copy of RotatingFileHandler's
> doRollover method with a one-line change.
>   - The proposed fix is functionally equivalent to the current code
> for all currently working uses.

You may just as well monkeypatch os.rename() to fallback on
shutil.move() if the filenames are on a /dev/shm filesystem (or you
could bug QNX to fix their broken filesystem...).

From a code quality and readability standpoint, os.rename() conveys the
intended semantics clearly, while shutil.move() doesn't, so switching to
shutil.move() in the stdlib would be a regression. Also, doing this in
logging would open the door to doing the same thing in other modules.
Even a critical piece of infrastructure such as importlib relies on
os.rename() working properly.
History
Date User Action Args
2012-11-11 13:57:52pitrousetrecipients: + pitrou, vinay.sajip, r.david.murray, serhiy.storchaka, pconnell
2012-11-11 13:57:52pitroulinkissue16449 messages
2012-11-11 13:57:51pitroucreate