Author pconnell
Recipients pconnell, pitrou, r.david.murray, serhiy.storchaka, vinay.sajip
Date 2012-11-11.12:38:20
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1352637501.24.0.768752389311.issue16449@psf.upfronthosting.co.za>
In-reply-to
Content
I'm not convinced that it matters whether the rename or move is atomic. Can anyone come up with a quick concrete example?


I see two scenarios:

1. The process crashes during a copy in shutils.move(). In this case, some logs will be duplicated across the files involved in the copy.

2. Other threads emit logs during the rollover. Given that the IO lock is acquired in Handler.handle() before calling emit(), this is fine.


While the first case isn't ideal, I don't think there can be any loss of logs.
History
Date User Action Args
2012-11-11 12:38:21pconnellsetrecipients: + pconnell, vinay.sajip, pitrou, r.david.murray, serhiy.storchaka
2012-11-11 12:38:21pconnellsetmessageid: <1352637501.24.0.768752389311.issue16449@psf.upfronthosting.co.za>
2012-11-11 12:38:21pconnelllinkissue16449 messages
2012-11-11 12:38:20pconnellcreate