➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients loewis, serhiy.storchaka, vstinner
Date 2012-10-30.01:02:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1351558952.83.0.460277416214.issue16311@psf.upfronthosting.co.za>
In-reply-to
Content 
"Soon I'll post a patch, which speeds up unicode-escape and raw-unicode-escape decoders to 1.5-3x. Also there are not yet reviewed patches for UTF-32 (issue14625) and charmap (issue14850) decoders. Will be merge conflicts."

codecs_writer.patch doesn't change too much the core of decoders, but mostly the code before and after the loop, and error handling. You can still use PyUnicode_WRITE, PyUnicode_READ, memcpy(), etc.

"But I will review the patch."

If you review the patch, please check that how the buffer is allocated. It should not be overallocated by default, only on the first error. Overallocation can kill performances when it is not necessary (especially on Windows).
History
Date User Action Args
2012-10-30 01:02:32vstinnersetrecipients: + vstinner, loewis, serhiy.storchaka
2012-10-30 01:02:32vstinnersetmessageid: <1351558952.83.0.460277416214.issue16311@psf.upfronthosting.co.za>
2012-10-30 01:02:32vstinnerlinkissue16311 messages
2012-10-30 01:02:32vstinnercreate