Author vstinner
Recipients amaury.forgeotdarc, belopolsky, msmhrt, serhiy.storchaka, vstinner
Date 2012-10-25.20:30:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1351197020.2.0.858120322209.issue16322@psf.upfronthosting.co.za>
In-reply-to
Content
>I see in 3.3 PyUnicode_DecodeFSDefaultAndSize() was replaced
> by PyUnicode_DecodeLocale().

Related changes:

 - 8620e6901e58 for the issue #5905
 - 279b0aee0cfb for the issue #13560

I wrote 8620e6901e58 for Linux, when the wcsftime() function is missing.

The problem is the changeset 279b0aee0cfb: it introduces a regression on Windows. It looks like PyUnicode_DecodeFSDefault() and PyUnicode_DecodeFSDefault() use a different encoding on Windows.

I suppose that we need to add an #ifdef MS_WINDOWS to use PyUnicode_DecodeFSDefault() on Windows, and PyUnicode_DecodeFSDefault() on Linux.

See also the issue #10653: time.strftime() uses strftime() (bytes) instead of wcsftime() (unicode) on Windows, because wcsftime() and tzname format the timezone differently.
History
Date User Action Args
2012-10-25 20:30:20vstinnersetrecipients: + vstinner, amaury.forgeotdarc, belopolsky, serhiy.storchaka, msmhrt
2012-10-25 20:30:20vstinnersetmessageid: <1351197020.2.0.858120322209.issue16322@psf.upfronthosting.co.za>
2012-10-25 20:30:20vstinnerlinkissue16322 messages
2012-10-25 20:30:19vstinnercreate