Message 173530 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	orsenthil
Recipients	orsenthil
Date	2012-10-22.15:29:05
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1350919745.8.0.0839924289599.issue16301@psf.upfronthosting.co.za>
In-reply-to

Content
localhost() returns a string and thishost() returns tuple. In urllib/request.py, for file:// protocol, there is a verification to check to if the host is in the localhost and check happens: socket.gethostbyname(host) in (localhost() + thishost())): This is clearly wrong for the above mentioned reason. It should be changed to this, wrapping localhost with tuple() or making localhost return a tuple, which will be consistent with thishost socket.gethostbyname(host) in (tuple(localhost()) + thishost())):

localhost() returns a string and thishost() returns tuple. In urllib/request.py, for file:// protocol, there is a verification to check to if the host is in the localhost and check happens:

socket.gethostbyname(host) in (localhost() + thishost())):

This is clearly wrong for the above mentioned reason. It should be changed to this, wrapping localhost with tuple() or making localhost return a tuple, which will be consistent with thishost

socket.gethostbyname(host) in (tuple(localhost()) + thishost())):

History
Date	User	Action	Args
2012-10-22 15:29:05	orsenthil	set	recipients: + orsenthil
2012-10-22 15:29:05	orsenthil	set	messageid: <1350919745.8.0.0839924289599.issue16301@psf.upfronthosting.co.za>
2012-10-22 15:29:05	orsenthil	link	issue16301 messages
2012-10-22 15:29:05	orsenthil	create