Message172968
Chris Calloway, let's move this forward. I want to see more tests for filecmp ASAP.
Please address Chris Jerdonek's points in a new patch made vs. fresh default branch (3.4), at this point "cd"ing (before the test_cwd thing is done). For testing code, practicality beats purity. Having these tests in place will help moving other issues forward (i.e. #15454). Also, as Chris Jerdonek has mentioned, having as little as possible in each test_ method is a good practice, and older test code that doesn't follow it can be fixed later (patches welcome). |
|
Date |
User |
Action |
Args |
2012-10-15 13:05:23 | eli.bendersky | set | recipients:
+ eli.bendersky, chris.jerdonek, cbc |
2012-10-15 13:05:23 | eli.bendersky | set | messageid: <1350306323.01.0.958450931667.issue15518@psf.upfronthosting.co.za> |
2012-10-15 13:05:22 | eli.bendersky | link | issue15518 messages |
2012-10-15 13:05:22 | eli.bendersky | create | |
|