➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ronaldoussoren
Recipients Kristof.Keppens, Paul, alanmcintyre, amaury.forgeotdarc, christian.heimes, craigds, dandrzejewski, enlavin, eric.araujo, gregory.p.smith, lambacck, loewis, nadeem.vawda, ronaldoussoren, segfault42, serhiy.storchaka
Date 2012-10-11.15:22:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1349968947.74.0.662066442274.issue9720@psf.upfronthosting.co.za>
In-reply-to
Content 
I'd write the extended header when the current file size is larger than the zip64 limit (that is, when 'st.st_size > ZIP64_LIMIT' in the write method.

That way the minimal header size is used whenever possible.

As you noted this can cause problems when the file grows beyond the limit while it is stored in the zipfile, but IMHO storing data while it is modified is asking for problems anyway.

BTW. I haven't actually review the patch yet.
History
Date User Action Args
2012-10-11 15:22:27ronaldoussorensetrecipients: + ronaldoussoren, loewis, gregory.p.smith, amaury.forgeotdarc, alanmcintyre, christian.heimes, nadeem.vawda, eric.araujo, lambacck, dandrzejewski, segfault42, craigds, enlavin, Paul, serhiy.storchaka, Kristof.Keppens
2012-10-11 15:22:27ronaldoussorensetmessageid: <1349968947.74.0.662066442274.issue9720@psf.upfronthosting.co.za>
2012-10-11 15:22:27ronaldoussorenlinkissue9720 messages
2012-10-11 15:22:27ronaldoussorencreate