Author sbt
Recipients Sebastian.Noack, asvetlov, jyasskin, kristjan.jonsson, mklauber, pitrou, sbt
Date 2012-10-01.09:52:23
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1349085143.64.0.281167985679.issue8800@psf.upfronthosting.co.za>
In-reply-to
Content
> @richard: I'm sorry, but both of my patches contain changes to 
> 'Lib/threading.py' and can be applied on top of Python 3.3.0. So can you 
> explain what do you mean, by missing the changes to threading.py?

I was reading the Rietveld review page

    http://bugs.python.org/review/8800/#ps6111

which only shows changes to multiprocessing/__init__.py and multiprocessing/synchronize.py.

The patch looks like it was produced using git rather than hg, so perhaps Rietveld got confused by this.  In that case it is a bug in Rietveld that it produced a partial review instead of producing no review.

> # unpack the the object into two variables and pass them separately around
> shrd_lock, excl_lock = ShrdExclLock()
> 
> Thread(target=reader, args=(shrd_lock,)).start()
> Thread(target=writer, args=(excl_lock,)).start)

Although using namedtuple is probably a good idea, I don't think it really adds much flexibility.  This example could just as easily be written

  selock = ShrdExclLock()

  Thread(target=reader, args=(selock.shared,)).start()
  Thread(target=writer, args=(selock.exclusive,)).start)
History
Date User Action Args
2012-10-01 09:52:23sbtsetrecipients: + sbt, pitrou, kristjan.jonsson, jyasskin, asvetlov, mklauber, Sebastian.Noack
2012-10-01 09:52:23sbtsetmessageid: <1349085143.64.0.281167985679.issue8800@psf.upfronthosting.co.za>
2012-10-01 09:52:23sbtlinkissue8800 messages
2012-10-01 09:52:23sbtcreate