Message171375
> I find my first patch more readable and efficient, but if these comments
> are conformant to pep7.. Attaching updated patch (issue8425.3.patch)
It was only a suggestion. Both forms are good enougth.
> Yes, but bench.py is available, fell free to run it with whatever
> configuration; my example was done with a --with-pydebug and clang
> compiler.
Yes, I ran it in release mode (gcc, 32-bit Linux) and confirm your results.
In general except minor whitespace defects last patch LGTM. |
|
Date |
User |
Action |
Args |
2012-09-27 14:16:18 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, rhettinger, mark.dickinson, belopolsky, eric.smith, stutzbach, ezio.melotti, r.david.murray, abacabadabacaba, maker |
2012-09-27 14:16:18 | serhiy.storchaka | link | issue8425 messages |
2012-09-27 14:16:18 | serhiy.storchaka | create | |
|