Message171046
I added some comments on Rietveld.
Apart from the bug in _PyLong_AsInt mentioned above, the patch mostly looks good. But there are many changes, some of which will have user-visible effects, and I think it's somewhat risky to make all these changes in bugfix releases (which now includes Python 3.3).
Perhaps there could be a smaller patch aimed at the bugfix releases? Ideally, each fix there should be backed by a regression test. |
|
Date |
User |
Action |
Args |
2012-09-23 15:38:38 | mark.dickinson | set | recipients:
+ mark.dickinson, serhiy.storchaka |
2012-09-23 15:38:38 | mark.dickinson | set | messageid: <1348414718.09.0.535918420549.issue15989@psf.upfronthosting.co.za> |
2012-09-23 15:38:37 | mark.dickinson | link | issue15989 messages |
2012-09-23 15:38:37 | mark.dickinson | create | |
|