Message 170868 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	ezio.melotti
Recipients	benjamin.peterson, eng793, ezio.melotti
Date	2012-09-21.09:06:21
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1348218382.49.0.243261405456.issue15845@psf.upfronthosting.co.za>
In-reply-to

Content
- if basename == '': + if len(basename) == 0: This should be "if not basename:" - if tail == curdir: + cdir = curdir + if isinstance(tail, bytes): + cdir = bytes(curdir, 'ASCII') + if tail == cdir: This will raise an error if curdir is a non-ascii str, so, unless the same error was already raised later in the code, this is backward incompatible.

-    if basename == '':
+    if len(basename) == 0:

This should be "if not basename:"


-        if tail == curdir:
+        cdir = curdir
+        if isinstance(tail, bytes):
+            cdir = bytes(curdir, 'ASCII')
+        if tail == cdir:

This will raise an error if curdir is a non-ascii str, so, unless the same error was already raised later in the code, this is backward incompatible.

History
Date	User	Action	Args
2012-09-21 09:06:22	ezio.melotti	set	recipients: + ezio.melotti, benjamin.peterson, eng793
2012-09-21 09:06:22	ezio.melotti	set	messageid: <1348218382.49.0.243261405456.issue15845@psf.upfronthosting.co.za>
2012-09-21 09:06:21	ezio.melotti	link	issue15845 messages
2012-09-21 09:06:21	ezio.melotti	create