Message170057
Actually, I've found a couple of issues with the patch:
- it doesn't address seekable(); seekable() should also raise ValueError
- the test should be done with makefile(..., buffering=0), so that SocketIO is actually tested, rather than the buffered object wrapping it |
|
Date |
User |
Action |
Args |
2012-09-08 17:16:03 | pitrou | set | recipients:
+ pitrou, benjamin.peterson, stutzbach, hynek, eng793 |
2012-09-08 17:16:03 | pitrou | set | messageid: <1347124563.51.0.308538236405.issue15842@psf.upfronthosting.co.za> |
2012-09-08 17:16:03 | pitrou | link | issue15842 messages |
2012-09-08 17:16:02 | pitrou | create | |
|