Author ezio.melotti
Recipients daniel.wagner-hall, ezio.melotti, michael.foord, r.david.murray
Date 2012-09-04.13:14:54
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1346764494.94.0.38476537264.issue15836@psf.upfronthosting.co.za>
In-reply-to
Content
I missed the initial patch.  What I was thinking about was to use simply

with self.assertRaises(TypeError):
    self.assertRaises(1)

instead of:
 
+        ctx = self.assertRaises(TypeError)
+        with ctx:
+            self.assertRaises(1)
+        self.assertIsInstance(ctx.exception, TypeError)

or

+        try:
+            self.assertRaises(1)
+            self.fail("Expected TypeError")
+        except TypeError:
+            pass

Unless I'm missing something, all these should be equivalent.
You could even use assertRaisesRegex to check the error message if you think that's appropriate.
History
Date User Action Args
2012-09-04 13:14:54ezio.melottisetrecipients: + ezio.melotti, r.david.murray, michael.foord, daniel.wagner-hall
2012-09-04 13:14:54ezio.melottisetmessageid: <1346764494.94.0.38476537264.issue15836@psf.upfronthosting.co.za>
2012-09-04 13:14:54ezio.melottilinkissue15836 messages
2012-09-04 13:14:54ezio.melotticreate