Author chris.jerdonek
Recipients asvetlov, chris.jerdonek, cvrebert, docs@python, ned.deily
Date 2012-09-03.19:08:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1346699309.99.0.759957449698.issue15533@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks, Andrew.  Regarding your comment, it was a deliberate choice not to do the additional check because I wanted each test to check only one thing.  But I am okay with adding the additional check.

Regarding the patch, should all of the methods now do something similar to what test_cwd() does?

+        # We cannot use os.path.realpath to canonicalize the path,
+        # since it doesn't expand Tru64 {memb} strings. See bug 1063571.
+        cwd = os.getcwd()
+        os.chdir(tmpdir)
+        tmpdir = os.getcwd()

It looks like test_cwd() may have needed to apply this treatment to have more reliable string-matching in the assert.  Otherwise, why is tmpdir being re-assigned to?
History
Date User Action Args
2012-09-03 19:08:30chris.jerdoneksetrecipients: + chris.jerdonek, ned.deily, cvrebert, asvetlov, docs@python
2012-09-03 19:08:29chris.jerdoneksetmessageid: <1346699309.99.0.759957449698.issue15533@psf.upfronthosting.co.za>
2012-09-03 19:08:29chris.jerdoneklinkissue15533 messages
2012-09-03 19:08:29chris.jerdonekcreate