Message169393
Yes, something along the lines of that patch is what I was thinking. BTW, this is only necessary for the errpipe_write fd. errpipe_read is for the parent process.
I'm going to do it within _create_pipe so that the optimal _posixsubprocess.cloexec_pipe pipe2() based implementation can be used when possible rather than needing to call _set_cloexec() on the dup'ed fd.
There are some recent Linux specific possibilities such as fcntl with F_DUPFD, or better F_DUPFD_CLOEXEC, that would make this a single call. Using that may be overkill for this situation but it looks easy enough while I'm in there. |
|
Date |
User |
Action |
Args |
2012-08-29 16:34:45 | gregory.p.smith | set | recipients:
+ gregory.p.smith, pitrou, ezio.melotti, cvrebert, rosslagerwall, sarum9in |
2012-08-29 16:34:45 | gregory.p.smith | set | messageid: <1346258085.46.0.874230536473.issue15798@psf.upfronthosting.co.za> |
2012-08-29 16:34:44 | gregory.p.smith | link | issue15798 messages |
2012-08-29 16:34:44 | gregory.p.smith | create | |
|