This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gregory.p.smith
Recipients cvrebert, ezio.melotti, gregory.p.smith, pitrou, rosslagerwall, sarum9in
Date 2012-08-29.16:34:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1346258085.46.0.874230536473.issue15798@psf.upfronthosting.co.za>
In-reply-to
Content
Yes, something along the lines of that patch is what I was thinking.  BTW, this is only necessary for the errpipe_write fd.  errpipe_read is for the parent process.

I'm going to do it within _create_pipe so that the optimal _posixsubprocess.cloexec_pipe pipe2() based implementation can be used when possible rather than needing to call _set_cloexec() on the dup'ed fd.

There are some recent Linux specific possibilities such as fcntl with F_DUPFD, or better F_DUPFD_CLOEXEC, that would make this a single call. Using that may be overkill for this situation but it looks easy enough while I'm in there.
History
Date User Action Args
2012-08-29 16:34:45gregory.p.smithsetrecipients: + gregory.p.smith, pitrou, ezio.melotti, cvrebert, rosslagerwall, sarum9in
2012-08-29 16:34:45gregory.p.smithsetmessageid: <1346258085.46.0.874230536473.issue15798@psf.upfronthosting.co.za>
2012-08-29 16:34:44gregory.p.smithlinkissue15798 messages
2012-08-29 16:34:44gregory.p.smithcreate