Author serhiy.storchaka
Recipients barry, ezio.melotti, jcea, petri.lehtinen, r.david.murray, serhiy.storchaka
Date 2012-08-29.08:46:25
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1346229987.5.0.732108937854.issue15802@psf.upfronthosting.co.za>
In-reply-to
Content
Yes, the previous check nonsensical in two cases -- comparing strings and comparing with wrong value.

groups[0] -- current seconds (str),
groups[1] -- current milliseconds (str),
previous_groups[0] -- previous seconds (str),
previous_groups[1] -- previous milliseconds (str).

As I understand sensible check should be: current seconds >= previous seconds and if current seconds == previous seconds then current milliseconds >= previous milliseconds.

In other words, (int(groups[0]), int(groups[1])) >= (int(previous_groups[0]), int(previous_groups[1])).
History
Date User Action Args
2012-08-29 08:46:27serhiy.storchakasetrecipients: + serhiy.storchaka, barry, jcea, ezio.melotti, r.david.murray, petri.lehtinen
2012-08-29 08:46:27serhiy.storchakasetmessageid: <1346229987.5.0.732108937854.issue15802@psf.upfronthosting.co.za>
2012-08-29 08:46:26serhiy.storchakalinkissue15802 messages
2012-08-29 08:46:25serhiy.storchakacreate