➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author daniel-black
Recipients daniel-black, giampaolo.rodola, grooverdan, pitrou, r.david.murray
Date 2012-08-22.07:48:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1345621712.69.0.463224899071.issue10852@psf.upfronthosting.co.za>
In-reply-to
Content 
> Thanks for the patch
> Daniel. 3.3 is nearing the release candidate phase, so I'm re-targetting to 3.4. I'll take a detailed look soon.

Welcome. Just noticed conflicts with #4473 in the client POP implementation. Hopefully they are close anyway.

> (I suppose there's no easy way to write automated tests for this, unfortunately)
Well since #8109 writes the server SNI its getting easier.

In Lib/test/test_ssl.py combined with the changes of #8109 it would seem that changing ConnectionHandler.run to respond to "AUTH TLS", "AUTH SSL" (ftp) and "STLS" for pop (preempt #4473).

Changing server_params_test to support a proper arguments that correspond the the client protocol would be the way to do it.

> By the way, could you sign a contributor agreement
yes - emailed in.
History
Date User Action Args
2012-08-22 07:48:32daniel-blacksetrecipients: + daniel-black, pitrou, giampaolo.rodola, r.david.murray, grooverdan
2012-08-22 07:48:32daniel-blacksetmessageid: <1345621712.69.0.463224899071.issue10852@psf.upfronthosting.co.za>
2012-08-22 07:48:32daniel-blacklinkissue10852 messages
2012-08-22 07:48:31daniel-blackcreate