This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author cbc
Recipients cbc, chris.jerdonek
Date 2012-08-01.02:47:52
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1343789273.99.0.26780173203.issue15518@psf.upfronthosting.co.za>
In-reply-to
Content
> Would it be possible to structure things so that you have tests like test_report(), test_report_partial_closure(), etc?

Yes, I would prefer that structure. I was just being consistent, as you said, with the prevailing style of the existing tests. I will provide another patch with tests separated into report method concerns as you suggest and I agree.

> Also, is there any reason you need to be using a regular expression as opposed to an exact string match?

Yes, the setUp method uses tempfile-generated directory names (and that's actually one of the few good things about the existing tests). The tempfile-generated directory names are part of the report method output and are not known in advance. So we cannot construct an exact string match in advance.
History
Date User Action Args
2012-08-01 02:47:54cbcsetrecipients: + cbc, chris.jerdonek
2012-08-01 02:47:53cbcsetmessageid: <1343789273.99.0.26780173203.issue15518@psf.upfronthosting.co.za>
2012-08-01 02:47:53cbclinkissue15518 messages
2012-08-01 02:47:52cbccreate