Message167077
> Would it be possible to structure things so that you have tests like test_report(), test_report_partial_closure(), etc?
Yes, I would prefer that structure. I was just being consistent, as you said, with the prevailing style of the existing tests. I will provide another patch with tests separated into report method concerns as you suggest and I agree.
> Also, is there any reason you need to be using a regular expression as opposed to an exact string match?
Yes, the setUp method uses tempfile-generated directory names (and that's actually one of the few good things about the existing tests). The tempfile-generated directory names are part of the report method output and are not known in advance. So we cannot construct an exact string match in advance. |
|
Date |
User |
Action |
Args |
2012-08-01 02:47:54 | cbc | set | recipients:
+ cbc, chris.jerdonek |
2012-08-01 02:47:53 | cbc | set | messageid: <1343789273.99.0.26780173203.issue15518@psf.upfronthosting.co.za> |
2012-08-01 02:47:53 | cbc | link | issue15518 messages |
2012-08-01 02:47:52 | cbc | create | |
|