Author taihyun.hwang
Recipients taihyun.hwang
Date 2012-07-31.22:08:20
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Attached patch enables ASDL parser to construct fields in the right order.

It resolves the issue below in Parser/
# XXX can't I just construct things in the right order?

We can safely use left-recursive grammar since Parser/ implements Earley parser.

The patch doesn't affect Python-ast.[ch] as expected.

$ make Include/Python-ast.h Python/Python-ast.c
$ diff -s ~/test/Python-ast.h Include/Python-ast.h
Files /home/xenosoz/test/Python-ast.h and Include/Python-ast.h are identical
$ diff -s ~/test/Python-ast.c Python/Python-ast.c
Files /home/xenosoz/test/Python-ast.c and Python/Python-ast.c are identical

Time consumption before/after the patch:
-- before patch --
time make Include/Python-ast.h
real    0m0.578s \ user    0m0.500s \ sys     0m0.060s

time make Python/Python-ast.c
real    0m0.687s \ user    0m0.620s \ sys     0m0.050s

-- after patch --
$ time make Include/Python-ast.h
real    0m0.588s \ user    0m0.510s \ sys     0m0.060s

$ time make Python/Python-ast.c
real    0m0.677s \ user    0m0.630s \ sys     0m0.030s

It touches:
Date User Action Args
2012-07-31 22:08:23taihyun.hwangsetrecipients: + taihyun.hwang
2012-07-31 22:08:23taihyun.hwangsetmessageid: <>
2012-07-31 22:08:22taihyun.hwanglinkissue15517 messages
2012-07-31 22:08:21taihyun.hwangcreate