This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients loewis, roger.serwy, serhiy.storchaka, terry.reedy
Date 2012-07-11.11:16:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1342005291.6314.35.camel@raxxla>
In-reply-to <1342000272.94.0.456241847246.issue15318@psf.upfronthosting.co.za>
Content
> Serhiy: can you please explicitly list what issues your patch fixes?

issue12967. And sys.std* in IDLE lacks other common sys.std* methods and
attributes.

> I can think of many *more* issues that your patch doesn't fix, e.g. sys.stdin.read(sys) and sys.stdout.read().

sys.stdin.read(sys) and sys.stdout.read() should not work.

> I'm quite opposed to monkey-patching, so I won't commit any patch that involves monkey-patching (i.e. _checked_text_writer). I'm also unsure what problem this change to monkey-patching solves: I believe the current code is fine in this respect as it stands.

I introduced _checked_text_writer, because the implementation of
_RPCFile was broken (I wrote this patch last evening and debug it this
morning). In addition, _RPCFile is a wrapper around RPCFile, which
itself is a wrapper. There are too many layers for me. If you are sure
that the current implementation of _RPCFile is correct, it is not
necessary.

> Before you grow the patch to add many more lines of code, please try to stick to the "one issue at a time" principle.

In IDLE sys.std* bad mimic text streams -- this is one issue.
History
Date User Action Args
2012-07-11 11:16:09serhiy.storchakasetrecipients: + serhiy.storchaka, loewis, terry.reedy, roger.serwy
2012-07-11 11:16:08serhiy.storchakalinkissue15318 messages
2012-07-11 11:16:07serhiy.storchakacreate