Author eric.araujo
Recipients JBernardo, amaury.forgeotdarc, benjamin.peterson, daniel.urban, eric.araujo, georg.brandl, mark.dickinson
Date 2012-07-06.00:21:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1341534065.7.0.124598202114.issue15245@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch.  It looks good to me, but I think that adding support for Ellipsis and adding a new parameter to allow extra names are two different requests, but someone more knowledgeable than me about AST may judge differently.  My rationale is that supporting Ellipsis literals is a no-brainer addition, whereas adding an argument to support things that are not actual Python literals may be rejected.  You don’t have to split your patch in two anyway, it’s easy to do if the dev who will commit wants to.

Each change would also need a doc update.
History
Date User Action Args
2012-07-06 00:21:06eric.araujosetrecipients: + eric.araujo, georg.brandl, amaury.forgeotdarc, mark.dickinson, benjamin.peterson, daniel.urban, JBernardo
2012-07-06 00:21:05eric.araujosetmessageid: <1341534065.7.0.124598202114.issue15245@psf.upfronthosting.co.za>
2012-07-06 00:21:05eric.araujolinkissue15245 messages
2012-07-06 00:21:04eric.araujocreate