Author Ray.Donnelly
Recipients Arfrever, BreamoreBoy, David.Kern, Greg.Hellings, Ray.Donnelly, WhiteTiger, doko, eric.araujo, kalev, marqvar, python-dev, rpetrov, tarek, vapier, wrobell
Date 2012-06-30.18:42:50
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1341081770.95.0.204958277651.issue3754@psf.upfronthosting.co.za>
In-reply-to
Content
NCURSES_INTERNALS stuff appears to be redundant:

Mac OS X curses.h, Linux curses.h and Windows PDCurses.h don't reference it, nor does the Python 3.3.0b1 source code. Of course, I haven't checked any other systems.

However: see http://bugs.python.org/issue14598, so maybe for older Linux ncurses and Cygwin it is still needed.

NCURSES_OPAQUE investigation:

Linux ncurses.h:
#ifndef NCURSES_OPAQUE
#define NCURSES_OPAQUE 0
#endif

Mac OS X ncurses.h:
#ifndef NCURSES_OPAQUE
#define NCURSES_OPAQUE 1
#endif

So for OSX we need to be defining it to 0...

but IMHO, these parts are not directly related to cross compilation support so shouldn't be part of this patch.
History
Date User Action Args
2012-06-30 18:42:51Ray.Donnellysetrecipients: + Ray.Donnelly, doko, wrobell, vapier, tarek, eric.araujo, rpetrov, Arfrever, WhiteTiger, BreamoreBoy, python-dev, David.Kern, Greg.Hellings, kalev, marqvar
2012-06-30 18:42:50Ray.Donnellysetmessageid: <1341081770.95.0.204958277651.issue3754@psf.upfronthosting.co.za>
2012-06-30 18:42:50Ray.Donnellylinkissue3754 messages
2012-06-30 18:42:50Ray.Donnellycreate