Author hynek
Recipients Arfrever, eric.araujo, ezio.melotti, georg.brandl, hynek, jcea, loewis, mrts, neologix, petri.lehtinen, pitrou, rosslagerwall, schmir, tarek, teamnoir
Date 2012-06-11.11:47:23
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1339415244.93.0.150645210648.issue4489@psf.upfronthosting.co.za>
In-reply-to
Content
Fair enough, I'm not going to question your obviously superior judgement here. :)

However, your patch currently breaks the test suite on any platform that uses the fallback rmtree: You forgot the ignore_errors=False in the _rmtree_unsafe signature (and obviously also the argument when calling it as a fallback).

You also didn't seem to have touched the tests?
History
Date User Action Args
2012-06-11 11:47:25hyneksetrecipients: + hynek, loewis, georg.brandl, jcea, pitrou, schmir, tarek, ezio.melotti, eric.araujo, Arfrever, mrts, neologix, teamnoir, rosslagerwall, petri.lehtinen
2012-06-11 11:47:24hyneksetmessageid: <1339415244.93.0.150645210648.issue4489@psf.upfronthosting.co.za>
2012-06-11 11:47:24hyneklinkissue4489 messages
2012-06-11 11:47:23hynekcreate