➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients benjamin.peterson, eric.smith, georg.brandl, larry, loewis, mark.dickinson, serhiy.storchaka
Date 2012-05-05.16:45:37
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1336236337.7.0.345494296829.issue14705@psf.upfronthosting.co.za>
In-reply-to
Content 
> Having meditated on it, I think either I should either just call
> PyErr_Occured, check for explicit failure (val < 0), or explicit success
> (val >= 0).  I've opted for the last of those.

Yes, I think that works; it avoids a relatively expensive PyErr_Occurred() call in the non-failure case.  The new code looks fine to me!
History
Date User Action Args
2012-05-05 16:45:37mark.dickinsonsetrecipients: + mark.dickinson, loewis, georg.brandl, larry, eric.smith, benjamin.peterson, serhiy.storchaka
2012-05-05 16:45:37mark.dickinsonsetmessageid: <1336236337.7.0.345494296829.issue14705@psf.upfronthosting.co.za>
2012-05-05 16:45:37mark.dickinsonlinkissue14705 messages
2012-05-05 16:45:37mark.dickinsoncreate