Author vinay.sajip
Recipients brian.curtin, catalin.iacob, georg.brandl, ocean-city, pitrou, skrah, terry.reedy, vinay.sajip, vstinner
Date 2012-05-05.09:35:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1336210544.81.0.912722118226.issue9116@psf.upfronthosting.co.za>
In-reply-to
Content
The AssertionError in Brian's initial post indicates that the test is too restrictive. Though the discussion here has talked about removing the popups altogether, the test passes on Windows with a small change: instead of assertEqual(), I used

    self.assertTrue(err.rstrip().startswith(
                    b'Fatal Python error:'
                    b' PyThreadState_Get: no current thread'))

Patch attached. As this seems to be a sufficiently specific test, but not too specific, I'd like to apply this patch soon, unless someone thinks the test needs to stay exactly like it is.
History
Date User Action Args
2012-05-05 09:35:44vinay.sajipsetrecipients: + vinay.sajip, georg.brandl, terry.reedy, pitrou, vstinner, ocean-city, brian.curtin, skrah, catalin.iacob
2012-05-05 09:35:44vinay.sajipsetmessageid: <1336210544.81.0.912722118226.issue9116@psf.upfronthosting.co.za>
2012-05-05 09:35:44vinay.sajiplinkissue9116 messages
2012-05-05 09:35:44vinay.sajipcreate