Author sbt
Recipients Arfrever, eric.araujo, gregory.p.smith, gvanrossum, larry, loewis, maubp, ncoghlan, pitrou, python-dev, r.david.murray, rosslagerwall, sbt, shaurz, vstinner
Date 2012-05-04.07:51:54
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1336117915.61.0.922507312184.issue14127@psf.upfronthosting.co.za>
In-reply-to
Content
> TBH I don't understand why it should crash, and therefore how your patch 
> helps.  Trying again using narrow strings should always work; indeed, the 
> code did that before I touched it.  Can you describe how it crashes?

The important part of the patch is the removal of the "!" in 

    if (!utime_read_time_arguments(&ua)) {

Without that change, if utime_read_time_arguments(&ua) fails then the unicode path is wrongly chosen.  Then PyUnicode_AsUnicode(upath) is called when upath has not been initialized.
History
Date User Action Args
2012-05-04 07:51:55sbtsetrecipients: + sbt, gvanrossum, loewis, gregory.p.smith, ncoghlan, pitrou, vstinner, larry, eric.araujo, Arfrever, r.david.murray, maubp, shaurz, rosslagerwall, python-dev
2012-05-04 07:51:55sbtsetmessageid: <1336117915.61.0.922507312184.issue14127@psf.upfronthosting.co.za>
2012-05-04 07:51:55sbtlinkissue14127 messages
2012-05-04 07:51:54sbtcreate