This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author hynek
Recipients Arfrever, benjamin.peterson, eric.araujo, hynek, neologix, pitrou
Date 2012-05-01.11:23:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1335871412.52.0.659839765605.issue14082@psf.upfronthosting.co.za>
In-reply-to
Content
I have answered to the (two weeks old :-/) review. There are three open questions in there we'll have to figure out before I fix the patch:

- should copyxattr() remove xattrs in dst that aren't present in src? Make it an option like `remove_missing_xattr`?

- use "None" for `namespaces` in copyxattrs() to indicate we want to copy all of them?

- add a ignore_errors option?

ISTM, that "all namespaces" don't make much sense without ignore_errors as there seem to be some internal xattr etc. 

Suggestion: copyxattrs() has ignore_errors as default and returns a list of xattr it couldn't copy as (xattr, exception) tuples? Or an "on error" handler like in rmtree? I'd prefer the first one as ISTM that failures happen more often than not.
History
Date User Action Args
2012-05-01 11:23:32hyneksetrecipients: + hynek, pitrou, benjamin.peterson, eric.araujo, Arfrever, neologix
2012-05-01 11:23:32hyneksetmessageid: <1335871412.52.0.659839765605.issue14082@psf.upfronthosting.co.za>
2012-05-01 11:23:31hyneklinkissue14082 messages
2012-05-01 11:23:31hynekcreate