Author lemburg
Recipients Arfrever, brett.cannon, eric.araujo, eric.snow, lemburg, ncoghlan, python-dev, r.david.murray
Date 2012-04-25.00:39:25
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <4F9747BA.2080708@egenix.com>
In-reply-to <4F974504.60100@egenix.com>
Content
Marc-Andre Lemburg wrote:
> Looking further I found this line in the Makefile:
> 
> ############################################################################
> # Importlib
> 
> Python/importlib.h: $(srcdir)/Lib/importlib/_bootstrap.py $(srcdir)/Python/freeze_importlib.py
>         ./$(BUILDPYTHON) $(srcdir)/Python/freeze_importlib.py \
>             $(srcdir)/Lib/importlib/_bootstrap.py Python/importlib.h
> 
> Since the patch modified _bootstrap.py, make wants to recreate importlib.h,
> but at that time $(BUILDPYTHON) doesn't yet exist.

I now ran 'make' after applying the patches to have the importlib.h
recreated.

This setup looks a bit fragile to me.

I think it would be better to make creation of the importlib.h an
explicit operation that has to be done in case the Python code
changes (e.g. by creating a make target build-importlib.h),
with the Makefile only warning about a needed update instead
of failing completely.
History
Date User Action Args
2012-04-25 00:39:26lemburgsetrecipients: + lemburg, brett.cannon, ncoghlan, eric.araujo, Arfrever, r.david.murray, python-dev, eric.snow
2012-04-25 00:39:26lemburglinkissue14605 messages
2012-04-25 00:39:25lemburgcreate