This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients csernazs, jyasskin, kristjan.jonsson, neologix, pitrou, python-dev
Date 2012-04-11.10:12:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1334138807.3328.1.camel@localhost.localdomain>
In-reply-to <>
> A few comments:
> 1)
>    with cv:
>        make_an_item_available()
> +       cv.notify()

Did I forget this? Ow.

> 2) one of the benefits of wait_for() is that it automates the tricky
> timekeeping needed if one wants an somewhat accurate timeout, you may
> want to mention this specifically.


> 3) the offending part.  I see that you don't want to use the technical
> terms of spurious wakeups or stolen wakeups. That's ok, but the
> resulting explanation is somwhat bogus.  I suggest the following:
> The ``while`` loop checking for the application's condition is
> necessary
> because :meth:`~Condition.wait` can return after an arbitrary long
> time, and the condition which prompted the :meth:`~Condition.notify`
> call may not yet, or no longer, hold true.  This is an inherent
> property of multi-threaded programming and the use of this pattern is
> essential for the robust use of Condition objects.

But, once again, "the condition may not yet hold true" is false.
However, the rest of the suggestion looks good, thanks.
Date User Action Args
2012-04-11 10:12:20pitrousetrecipients: + pitrou, csernazs, kristjan.jonsson, jyasskin, neologix, python-dev
2012-04-11 10:12:19pitroulinkissue8799 messages
2012-04-11 10:12:19pitroucreate