Author pitrou
Recipients Esben.Agerbæk.Black, belopolsky, lemburg, pitrou, vstinner
Date 2012-04-09.21:29:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1334006948.0.0.568650832597.issue14423@psf.upfronthosting.co.za>
In-reply-to
Content
Some comments:

- you also need to modify the C version in Modules/_datetimemodule.c
(make sure the tests exercise both versions!)

- the doc needs a "versionadded" tag

- I don't understand this:

+        if self.isocalendar()[1] != 1:
+            if self.weekday() > 3:  # Jan 1 is not in week one
+                self += timedelta(7 - self.weekday())

What if self.weekday() <= 3 ? Surely some adjustment is needed as well?
(you should probably add more tests to cover the various cases)

- this comment:

+        # Test that we get the OverflowError when the year has 52 weeks

seems wrong since ValueError is raised
History
Date User Action Args
2012-04-09 21:29:08pitrousetrecipients: + pitrou, lemburg, belopolsky, vstinner, Esben.Agerbæk.Black
2012-04-09 21:29:07pitrousetmessageid: <1334006948.0.0.568650832597.issue14423@psf.upfronthosting.co.za>
2012-04-09 21:29:07pitroulinkissue14423 messages
2012-04-09 21:29:07pitroucreate